Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 18, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: e9323c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 18, 2025 04:15 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 18, 2025 04:15 Inactive
@vercel
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 4:18am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 18, 2025 4:18am
login ⬜️ Skipped (Inspect) Feb 18, 2025 4:18am
thirdweb-www ⬜️ Skipped (Inspect) Feb 18, 2025 4:18am
wallet-ui ⬜️ Skipped (Inspect) Feb 18, 2025 4:18am

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 18, 2025 04:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 18, 2025 04:15 Inactive
@jnsdls jnsdls marked this pull request as ready for review February 18, 2025 04:15
@jnsdls jnsdls requested review from a team as code owners February 18, 2025 04:15
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Feb 18, 2025
Copy link
Member Author

jnsdls commented Feb 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls merged commit 647c285 into main Feb 18, 2025
30 of 35 checks passed
@jnsdls jnsdls deleted the add_abstract_chain_to_supported_networks branch February 18, 2025 04:16
@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (b182302) to head (e9323c8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6284      +/-   ##
==========================================
- Coverage   56.85%   56.83%   -0.03%     
==========================================
  Files        1168     1168              
  Lines       64677    64793     +116     
  Branches     5246     5264      +18     
==========================================
+ Hits        36772    36824      +52     
- Misses      27177    27241      +64     
  Partials      728      728              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b182302
packages 55.04% <ø> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 7 files with indirect coverage changes

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.7 s (+12.3% 🔺) 3.6 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 5.4 s (+10.48% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 212 ms (+11.12% 🔺) 324 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 154 ms (+29.5% 🔺) 164 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 537 ms (-0.23% 🔽) 923 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants